Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bookinfo MongoDB sample app on IPv6 cluster #53072

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix bookinfo MongoDB sample app on IPv6 cluster #53072

merged 1 commit into from
Sep 17, 2024

Conversation

mkralik3
Copy link
Contributor

@mkralik3 mkralik3 commented Sep 10, 2024 •
edited
Loading

Please provide a description of this PR:
Mongo DB from bookinfo samples doesn't work on IPv6 cluster ( tried on kind IPv6 only). It seems that the Mongo port is not bind correctly.
The ratings-v2 pod contains the error:

MongoNetworkError: failed to connect to server [mongodb:27017] on first connect [Error: read ECONNRESET

Reproducer with Kind IPv6 cluster: https://gist.github.com/mkralik3/815392209af83e8861293a27994c4e0b

Fix:
Added --ipv6 and --bind_ip_all args to the Mongo DB container.
Now, the mongo pod is able to bind IPv6 and IPv6, see the log:

...
{"t":{"$date":"2024-09-10T08:11:50.607+00:00"},"s":"I",  "c":"CONTROL",  "id":21951,   "ctx":"initandlisten","msg":"Options set by command line","attr":{"options":{"net":{"bindIp":"*","ipv6":true}}}}
...
{"t":{"$date":"2024-09-10T08:11:51.516+00:00"},"s":"I",  "c":"NETWORK",  "id":23015,   "ctx":"listener","msg":"Listening on","attr":{"address":"0.0.0.0"}}
{"t":{"$date":"2024-09-10T08:11:51.516+00:00"},"s":"I",  "c":"NETWORK",  "id":23015,   "ctx":"listener","msg":"Listening on","attr":{"address":"::"}}

Ref.: https://www.mongodb.com/docs/manual/core/security-mongodb-configuration/#ip-binding-in-self-managed-deployments

Tested on both IPv6 only and IPv4 only kind clusters and bookinfo app with ratings-v2 mongo db works correctly (see my reproducer above)

@mkralik3 mkralik3 requested a review from a team as a code owner September 10, 2024 14:15
@istio-policy-bot
Copy link

😊 Welcome @mkralik3! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 10, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mkralik3 / name: Matej Kralik (fb88946)

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2024
@istio-testing
Copy link
Collaborator

Hi @mkralik3. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@craigbox
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 17, 2024
@dhawton dhawton added the release-notes-none Indicates a PR that does not require release notes. label Sep 17, 2024
@dhawton
Copy link
Member

dhawton commented Sep 17, 2024

/test release-notes

@istio-testing istio-testing merged commit 60722ed into istio:master Sep 17, 2024
27 checks passed
luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024
Automator: merge upstream changes to openshift-service-mesh/istio@master
5555a5d 
* upstream/master:
  ambient: fix add+remove+add of iptables (istio#53063)
  Apply missing secret filter for discoverySelector (istio#53175)
  ambient: only set app tunnel if configured (istio#53155)
  Automator: update proxy@master in istio/istio@master (istio#53173)
  Fix bookinfo MongoDB on IPv6 cluster (istio#53072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhawton dhawton dhawton approved these changes

Assignees
No one assigned
Labels
area/user experience ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkralik3 @istio-policy-bot @istio-testing @craigbox @dhawton