skip overload actions for static listeners #52971
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
added
the
size/L
|
/retest |
| @@ -9,4 +9,5 @@ meshConfig: | |||
| defaultConfig: | |||
| proxyMetadata: | |||
| # 1.24 behaviour changes | |||
| ENABLE_DEFERRED_STATS_CREATION: "false" | |||
| ENABLE_DEFERRED_STATS_CREATION: "false" | |||
| BYPASS_OVERLOAD_MANAGER_FOR_STATIC_LISTENERS: "false" | |||
There was a problem hiding this comment.
For my context and understanding, what's the significance of adding this env variable here as opposed to in the pilot.env section?
There was a problem hiding this comment.
This is relevant to Pilot Agent - Not Pilot.
|
/retest |
| {{- if .bypass_overload_manager}} | ||
| "ignore_global_conn_limit": true, | ||
| "bypass_overload_manager": true, | ||
| {{ end}} |
There was a problem hiding this comment.
And you did not set overload_manager
There was a problem hiding this comment.
I think this is to allow bypassing overload manager if/when it is configured. In this PR I am not configuring it. If folks use overload manager via #14366 (comment) - they get this benefit.
We have to configure it via configuration https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/overload_manager/overload_manager#config-overload-manager - see as an example |
|
But i donot see the config in this patch? |
No. This just ensures, if overload config is enabled by some means(bootstrap merge for example), the static listeners are not counted under overload actions. This PR does not enable overload manager. |
|
@howardjohn @hzxuzhonghu Can you PTAL? |
There was a problem hiding this comment.
Need to emphasize this still need customizing bootstrap config #14366 (comment)
Fixes #52663
#41859
Please check any characteristics that apply to this pull request.