installer: fix missing labels on uninstall #52717
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
istio-testing
added
the
size/XS
howardjohn
force-pushed
the
install/fix-uninstall
branch
from
0a47d52 to
8193011
Compare
istio-testing
added
size/S
howardjohn
force-pushed
the
install/fix-uninstall
branch
from
8193011 to
4be04b9
Compare
This is causing postsubmit to break. We have test coverage here, it just seems to be the check is flaky -- we are checking that we did *not* remove something, but the removal is async.
howardjohn
force-pushed
the
install/fix-uninstall
branch
from
4be04b9 to
e190c04
Compare
|
/retest |
hanxiaop
approved these changes
Aug 16, 2024
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
* upstream/master: installer: fix missing labels on uninstall (istio#52717) Update various dependencies (istio#52683) Workaround calico issue in integration test (istio#52720) Auto detect cilium incompatibility during install (istio#52624) Fix lint issues (istio#52721) Update Go dependencies to 1.31 (istio#52661) Automator: update proxy@master in istio/istio@master (istio#52712) Automator: update common-files@master in istio/istio@master (istio#52685) installation: rewrite the code (istio#52541) Automator: update ztunnel@master in istio/istio@master (istio#52711) adding ds support for autoallocated IP in getAllAddressesForProxy (istio#52680)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing postsubmit to break. We have test coverage here, it just
seems to be the check is flaky -- we are checking that we did not
remove something, but the removal is async.