add names to static listeners #52501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
|
@howardjohn @hzxuzhonghu WDYT? Would it create any problems? |
|
I donot see any influence to users, i think no one is operating on static listener by name So Lgtm |
howardjohn
approved these changes
Aug 5, 2024
howardjohn
added
release-notes-none
|
/retest |
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
* upstream/master: (67 commits) Add release notes for dual-stack support promotion (istio#52524) Automator: update proxy@master in istio/istio@master (istio#52515) add name (istio#52501) Allow setting resources to null in gateway chart (istio#52514) Fix replacements errors in helm charts and templates (istio#52459) hand written IstioEndpoint deepcopy (istio#52485) operator: remove `profile` commands (istio#52468) Automator: update proxy@master in istio/istio@master (istio#52506) Automator: update proxy@master in istio/istio@master (istio#52505) Automator: update proxy@master in istio/istio@master (istio#52504) Automator: update ztunnel@master in istio/istio@master (istio#52502) Fix typo of InsertDataToConfigMap func description (istio#52491) Fix stale GVK in benchmark test (istio#52482) Bug/stale cert expiration logs (istio#52466) Automator: update ztunnel@master in istio/istio@master (istio#52496) Automator: update proxy@master in istio/istio@master (istio#52495) operator: move proto from api to this repo (istio#52472) remove unneeded func isAllowedKubernetesAudience (istio#52489) operator: misc code cleanup (istio#52467) ambient: do not allow service waypoint to have a waypoint (istio#52480) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add names to static listeners to better detect duplicates and not let envoy generate random names. No functional changes.