operator: remove profile commands
#52468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/XL
howardjohn
force-pushed
the
operator/drop-profile-dump
branch
from
b409c5e to
b2cd39b
Compare
While these may provide a small trivial amount of value, they are just that -- trivial value. Its best to keep these as just basic documentation.
howardjohn
force-pushed
the
operator/drop-profile-dump
branch
from
b2cd39b to
1e2d18c
Compare
|
I think we should not remove a non-experimental command directly? |
Agree that the command provides little value, but one thing is that the doc is usually not kept up-to-date, and right now it’s still missing the recently added profiles. |
The doc should probably just directly link to If we really want to individually document profiles and treat them like describable/inspectable artifacts, we are probably ultimately better off making profile == wrapper chart, as charts already can carry documentation, have manifests, and show up with But short of that? I'd rather just link to the directory listing. |
bleggett
approved these changes
Aug 2, 2024
hanxiaop
approved these changes
Aug 5, 2024
sergii-ssh
added a commit
to GoogleCloudPlatform/anthos-service-mesh-packages
that referenced
this pull request
Sep 12, 2024
Those were removed from istioctl istio/istio#52468
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
* upstream/master: (67 commits) Add release notes for dual-stack support promotion (istio#52524) Automator: update proxy@master in istio/istio@master (istio#52515) add name (istio#52501) Allow setting resources to null in gateway chart (istio#52514) Fix replacements errors in helm charts and templates (istio#52459) hand written IstioEndpoint deepcopy (istio#52485) operator: remove `profile` commands (istio#52468) Automator: update proxy@master in istio/istio@master (istio#52506) Automator: update proxy@master in istio/istio@master (istio#52505) Automator: update proxy@master in istio/istio@master (istio#52504) Automator: update ztunnel@master in istio/istio@master (istio#52502) Fix typo of InsertDataToConfigMap func description (istio#52491) Fix stale GVK in benchmark test (istio#52482) Bug/stale cert expiration logs (istio#52466) Automator: update ztunnel@master in istio/istio@master (istio#52496) Automator: update proxy@master in istio/istio@master (istio#52495) operator: move proto from api to this repo (istio#52472) remove unneeded func isAllowedKubernetesAudience (istio#52489) operator: misc code cleanup (istio#52467) ambient: do not allow service waypoint to have a waypoint (istio#52480) ...
sergii-ssh
added a commit
to GoogleCloudPlatform/anthos-service-mesh-packages
that referenced
this pull request
Oct 17, 2024
* Remove usage of profile commands. Those were removed from istioctl istio/istio#52468 * wip * wip * wip * wip * wip * Download istioctl for CI * wip * wip
m4ver1k
added a commit
to m4ver1k/istio.io
that referenced
this pull request
Nov 9, 2024
istioctl profile command was removed in PR istio/istio#52468 updating docs with these changes.
11 tasks
istio-testing
pushed a commit
to istio/istio.io
that referenced
this pull request
Nov 10, 2024
* removed istioctl profile cmd references (en) istioctl profile command was removed in PR istio/istio#52468 updating docs with these changes. * link to ingress gateway values file Co-authored-by: Craig Box <craig.box@gmail.com> * link to built in profiles --------- Co-authored-by: Craig Box <craig.box@gmail.com>
istio-testing
pushed a commit
to istio-testing/istio.io
that referenced
this pull request
Nov 20, 2024
istioctl profile command was removed in PR istio/istio#52468 updating docs with these changes.
istio-testing
added a commit
to istio/istio.io
that referenced
this pull request
Nov 20, 2024
* removed istioctl profile cmd references (en) istioctl profile command was removed in PR istio/istio#52468 updating docs with these changes. * link to ingress gateway values file Co-authored-by: Craig Box <craig.box@gmail.com> * link to built in profiles --------- Co-authored-by: Adarsh K Kumar <adarshkkumar@gmail.com> Co-authored-by: Craig Box <craig.box@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While these may provide a small trivial amount of value, they are just
that -- trivial value. Its best to keep these as just basic
documentation.