Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in-cluster operator #52090

Merged
merged 15 commits into from
Jul 29, 2024
Merged

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Jul 16, 2024

As per https://docs.google.com/document/d/1WCr_uEvGBDdnTaG2Z-UL2Md4DWS-yaEb3fkj_0mG2oI/edit, we will be removing the In Cluster Operator in Istio 1.24 (~4 months) (if the doc is approved)

The deprecation notice will go out with 1.23, but it has not yet been written.

This PR removes all of the operator code, including:

  • The integration tests
  • the operator subcommand in istioctl
  • Various deadcode after the cleanup

It does not attempt to do widespread refactoring that is enabled by the lack of the tech-debt of the operator. This will be done in a followup to simplify review. However, I did do some of the low hanging fruit

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Jul 16, 2024
@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 16, 2024
@howardjohn howardjohn changed the title operator/remove Remove in-cluster operator Jul 16, 2024
@howardjohn howardjohn marked this pull request as ready for review July 17, 2024 15:36
@howardjohn howardjohn requested review from a team as code owners July 17, 2024 15:36
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 17, 2024
@howardjohn howardjohn added the do-not-merge/hold Block automatic merging of a PR. label Jul 17, 2024
Copy link
Contributor

@bleggett bleggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Awesome.

I'm not reviewing this very closely because it's mostly deletion and the knock-on effects (if any) will work themselves out during 1.24, gotta just do it.

@hanxiaop
Copy link
Member

The README also has an introduction related to the operator: https://github.com/istio/istio?tab=readme-ov-file#introduction

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 18, 2024
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 18, 2024
@istio-testing
Copy link
Collaborator

istio-testing commented Jul 18, 2024

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-operator-controller_istio 79342a2 link true /test integ-operator-controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 19, 2024
@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged and removed needs-rebase Indicates a PR needs to be rebased before being merged labels Jul 19, 2024
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 28, 2024
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 29, 2024
@howardjohn howardjohn removed the do-not-merge/hold Block automatic merging of a PR. label Jul 29, 2024
@istio-testing istio-testing merged commit c2b027c into istio:master Jul 29, 2024
27 checks passed
bleggett added a commit to bleggett/istio that referenced this pull request Aug 1, 2024
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett added a commit to bleggett/istio that referenced this pull request Aug 1, 2024
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
kranurag7 added a commit to kranurag7/os that referenced this pull request Nov 8, 2024
in-cluster operator was removed here
istio/istio#52090

remove this file while copying
tools/packaging/common/gcp_envoy_bootstrap.json because this no longer
exists and was removed istio/istio#52097

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
kranurag7 added a commit to wolfi-dev/os that referenced this pull request Nov 15, 2024
⚠️ this is not backwards compatible so needs change on images side as
well.

important changes are: 
- in-cluster operator was removed via
istio/istio#52090
- gcp_envoy_bootstrap.json was removed via
istio/istio#52097


5ff8532
commit removed operator subpackage and avoids copying
gcp_envoy_bootstrap.json file to package at build time.

---------

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Co-authored-by: octo-sts[bot] <157150467+octo-sts@users.noreply.github.com>
Co-authored-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants