tests for #52003 #52012
Merged
tests for #52003 #52012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
istio-policy-bot
added
the
release-notes-none
istio-testing
added
the
size/M
MorrisLaw
reviewed
Jul 11, 2024
| @@ -945,6 +945,22 @@ var testGrid = []testCase{ | |||
| {msg.IneffectiveSelector, "Telemetry default/telemetry-ineffective"}, | |||
| }, | |||
| }, | |||
| { | |||
| name: "ServiceEntry Addresses Required Lower", | |||
There was a problem hiding this comment.
what do we mean by lower and upper in this context?
There was a problem hiding this comment.
case used for tcp in protocol to test the fix
There was a problem hiding this comment.
Tried to clarify the wording in the tests
Signed-off-by: ilrudie <ian.rudie@solo.io>
hzxuzhonghu
approved these changes
Jul 15, 2024
Happy to adjust it in a follow up. Do you have any suggestions or a specific name which is off? |
3 tasks
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
* upstream/master: rename function to match its behaviour (istio#52054) Manual bump of istio API (istio#52079) Move this as per TOC (istio#52013) ambient: do not mutate shared state in debug interface (istio#52075) add useful labels to helm templates for ztunnel (istio#52033) Automator: update proxy@master in istio/istio@master (istio#52063) Retry reset before request integration (istio#52032) Remove unused objectSelector from SidecarInjectorConfig (istio#52058) cleanup (istio#52046) tests for istio#52003 (istio#52012) remove deprecated cronjob api batch/v2alpha1 (istio#52042) Automator: update proxy@master in istio/istio@master (istio#52044) Automator: update go-control-plane in istio/istio@master (istio#51927) Automator: update proxy@master in istio/istio@master (istio#52040) Automator: update ztunnel@master in istio/istio@master (istio#52035) Simplified global management in ztunnel (istio#51749) Automator: update proxy@master in istio/istio@master (istio#52030) fix inconsistent behavior with the 'istio_agent_cert_expiry_seconds' metric (istio#52005) removed PILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKING and PILOT_DISTRIBUTION_HISTORY_RETENTION (istio#52021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
add unit test cases for #52003