Cleanup trust domain to not use globals #51205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/L
Before: from mesh config, set a global var After: read from mesh config This is a general code smell to use globals, and also the source of a bug (and a few many years ago IIRC). Most of the churn is in tests
howardjohn
force-pushed
the
istiod/drop-td-globals
branch
from
6fe84f5 to
d982f7f
Compare
bleggett
approved these changes
May 22, 2024
lei-tang
approved these changes
May 22, 2024
|
As with #51204 |
hzxuzhonghu
approved these changes
May 23, 2024
|
/retest |
Closed
2 tasks
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
* upstream/master: CNI shouldn't pass trustdomain down (istio#51204) Cleanup trust domain to not use globals (istio#51205) Bugfix: actually use v6 SNAT IP inpod (istio#51221) Automator: update ztunnel@master in istio/istio@master (istio#51219) Automator: update proxy@master in istio/istio@master (istio#51215) Pick up mesh config change to not depend on k8s (istio#51041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: from mesh config, set a global var
After: read from mesh config
This is a general code smell to use globals, and also the source of a
bug (and a few many years ago IIRC).
Most of the churn is in tests