Fix webhooks created by tag set being deleted after re-installation
#48780
Conversation
|
Skipping CI for Draft Pull Request. |
istio-testing
added
the
do-not-merge/work-in-progress
istio-testing
added
the
size/S
hanxiaop
added
cherrypick/release-1.19
istio-testing
added
the
size/S
istio-testing
removed
the
do-not-merge/work-in-progress
| area: installation | ||
| issue: | ||
| - 47423 | ||
| releaseNotes: |
There was a problem hiding this comment.
nit: I'm a little worried that people may be confused because the wording and issue number on this are identical to the other #47538 which has already been included in https://istio.io/latest/news/releases/1.20.x/announcing-1.20.1/
maybe I'm over thinking it, or that people pay too close attention to our release notes.
There was a problem hiding this comment.
@GregHanson Yes, this may be a problem, but I'm not sure which option is the best since the old patch didn't fix the problem well. Alternatively, I could take a close eye on the new patch release and remove the note in 1.20.1 on the doc site when 1.20.3 is released, although maybe we didn't do this before,. I'm the RM for both 1.19 and 1.20, and the note should be put in the right place instead of dups.
There was a problem hiding this comment.
I'm OK with it going in as-is then if you're willing to adjust prior release notes
|
In response to a cherrypick label: new pull request created: #48820 |
|
In response to a cherrypick label: new pull request created: #48821 |
…istio#48780) * fix user created tag being deleted after re-installation * add releasenotes
…istio#48780) * fix user created tag being deleted after re-installation * add releasenotes
Please provide a description of this PR:
Fix #47423