Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make httpbin samples work on OpenShift #47922

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Make httpbin samples work on OpenShift #47922

merged 2 commits into from
Nov 20, 2023

Conversation

jwendell
Copy link
Member

No description provided.

@jwendell
Make httpbin samples work on OpenShift
0d97eea 
By using a non privileged port
@jwendell jwendell requested a review from a team as a code owner November 18, 2023 02:47
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2023
craigbox
craigbox reviewed Nov 18, 2023
View reviewed changes
Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I might wait for Eric to weigh in too - assume they continue to work fine on other distros?

@jwendell @dhawton
Update releasenotes/notes/make-httpbin-work-ocp.yaml
ed739dc 
Co-authored-by: Daniel Hawton <daniel@hawton.org>
@dhawton
Copy link
Member

dhawton commented Nov 20, 2023

LGTM, though I might wait for Eric to weigh in too - assume they continue to work fine on other distros?

I'm seeing nothing that would suggest otherwise in the PR. LGTM as well, agree with @ericvn's weigh in.

@jwendell
Copy link
Member Author

Yeah, I tried on kind as well just to make sure nothing breaks.

@jwendell
Copy link
Member Author

According to Slack, Eric's on vacation :/

dhawton
dhawton approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@dhawton dhawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with kind and validated working.

@istio-testing istio-testing merged commit 84ac8b9 into istio:master Nov 20, 2023
28 checks passed
@ericvn
Copy link
Contributor

ericvn commented Nov 27, 2023 •
edited
Loading

It looks like this might be causing an istio.io test failure in the authentication/authn-ppolicy tests, specifically the last part of https://preliminary.istio.io/latest/docs/tasks/security/authentication/authn-policy/#enable-mutual-tls-per-workload. After setting portLevelMtls to DISABLE, The test result has:

sleep.legacy to httpbin.bar: 000
command terminated with exit code 56

while the page shows:

sleep.legacy to httpbin.bar: 200

This occcurs for both the gateway api and istio api versions of the test.

@ericvn ericvn mentioned this pull request Nov 28, 2023
Merged
@zirain
Copy link
Member

zirain commented Dec 1, 2023 •
edited
Loading

after this PR, httpbin request python.org always.

2023-12-01T16:12:53.025Z] "- - -" 0 - - - "-" 517 0 5013 - "-" "-" "-" "-" "151.101.192.223:443" PassthroughCluster 10.244.0.9:44988 151.101.192.223:443 10.244.0.9:44972 - -
[2023-12-01T16:12:53.556Z] "- - -" 0 - - - "-" 517 0 5011 - "-" "-" "-" "-" "151.101.109.55:443" PassthroughCluster 10.244.0.9:50048 151.101.109.55:443 10.244.0.9:50038 - -
[2023-12-01T16:12:58.576Z] "- - -" 0 - - - "-" 517 0 5011 - "-" "-" "-" "-" "151.101.109.55:443" PassthroughCluster 10.244.0.9:43842 151.101.109.55:443 10.244.0.9:43836 - -
[2023-12-01T16:12:58.970Z] "- - -" 0 - - - "-" 517 0 5010 - "-" "-" "-" "-" "151.101.109.55:443" PassthroughCluster 10.244.0.9:43860 151.101.109.55:443 10.244.0.9:43846 - -
[2023-12-01T16:12:53.039Z] "- - -" 0 - - - "-" 1193 18485 12266 - "-" "-" "-" "-" "151.101.0.223:443" PassthroughCluster 10.244.0.9:53492 151.101.0.223:443 10.244.0.9:53486 - -
[2023-12-01T16:13:04.096Z] "- - -" 0 - - - "-" 1221 70479 1210 - "-" "-" "-" "-" "151.101.109.55:443" PassthroughCluster 10.244.0.9:42470 151.101.109.55:443 10.244.0.9:42466 - -
[2023-12-01T16:13:03.984Z] "- - -" 0 - - - "-" 1226 825397 1392 - "-" "-" "-" "-" "151.101.109.55:443" PassthroughCluster 10.244.0.9:42460 151.101.109.55:443 10.244.0.9:42450 - -
[2023-12-01T16:12:58.041Z] "- - -" 0 - - - "-" 1198 128573 7335 - "-" "-" "-" "-" "151.101.192.223:443" PassthroughCluster 10.244.0.9:45034 151.101.192.223:443 10.244.0.9:45024 - -
[2023-12-01T16:13:05.358Z] "- - -" 0 - - - "-" 517 0 5008 - "-" "-" "-" "-" "151.101.0.223:443" PassthroughCluster 10.244.0.9:49662 151.101.0.223:443 10.244.0.9:49656 - -
[2023-12-01T16:13:05.429Z] "- - -" 0 - - - "-" 517 0 5006 - "-" "-" "-" "-" "151.101.192.223:443" PassthroughCluster 10.244.0.9:35920 151.101.192.223:443 10.244.0.9:35908 - -
[2023-12-01T16:13:10.381Z] "- - -" 0 - - - "-" 517 0 5012 - "-" "-" "-" "-" "151.101.0.223:443" PassthroughCluster 10.244.0.9:49672 151.101.0.223:443 10.244.0.9:49668 - -
[2023-12-01T16:13:10.447Z] "- - -" 0 - - - "-" 517 0 5007 - "-" "-" "-" "-" "151.101.192.223:443" PassthroughCluster 10.244.0.9:35938 151.101.192.223:443 10.244.0.9:35924 - -
[2023-12-01T16:13:16.267Z] "- - -" 0 - - - "-" 1193 4750 1185 - "-" "-" "-" "-" "151.101.192.223:443" PassthroughCluster 10.244.0.9:51136 151.101.192.223:443 10.244.0.9:51126 - -
[2023-12-01T16:13:16.747Z] "- - -" 0 - - - "-" 1221 70903 704 - "-" "-" "-" "-" "151.101.109.55:443" PassthroughCluster 10.244.0.9:49222 151.101.109.55:443 10.244.0.9:49214 - -
[2023-12-01T16:13:16.289Z] "- - -" 0 - - - "-" 517 0 5012 - "-" "-" "-" "-" "151.101.128.223:443" PassthroughCluster 10.244.0.9:59322 151.101.128.223:443 10.244.0.9:59310 - -

This was referenced Dec 1, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox left review comments

@dhawton dhawton dhawton approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jwendell @dhawton @ericvn @zirain @craigbox @istio-testing