tools/bug-report: Reduce k8s API calls via "get" not "describe" #47918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
istio-testing
added
the
size/M
howardjohn
reviewed
Nov 17, 2023
| // GetDescribePods returns describe pods for istioNamespace. | ||
| func GetDescribePods(p *Params) (map[string]string, error) { | ||
| // GetPodInfo returns pod details for istioNamespace. | ||
| func GetPodInfo(p *Params) (map[string]string, error) { |
There was a problem hiding this comment.
I think GetK8sResources already includes pods. We can add nodes there as well?
Confusingly, all doesn't mean all. It includes pods, but not nodes.
howardjohn
approved these changes
Nov 17, 2023
Signed-off-by: Tony Allen <tony@allen.gg>
syw14
added
the
cherrypick/release-1.20
|
In response to a cherrypick label: new pull request created: #48216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
istioctl bug-reportwill use theget podsandget nodescommands for the report instead ofdescribe .... This reduces the amount of calls made to the k8s API and speeds up the generation of the bug report tool.