-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sets.String replace sets.Set[string] #47841
Conversation
Hi @sword-jin. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/release-notes-none |
This comment was marked as spam.
This comment was marked as spam.
/retest |
// Be aware that the order of elements is random so the string representation may vary. | ||
// Use it only for debugging and logging. | ||
func (s Set[T]) String() string { | ||
return fmt.Sprintf("%v", s.UnsortedList()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it look better using SortedList
?
Only internal changes: