Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sets.String replace sets.Set[string] #47841

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

sword-jin
Copy link
Member

@sword-jin sword-jin commented Nov 14, 2023

Only internal changes:

  • replace all sets.Set[string] by sets.String
  • add String() function to Set

@sword-jin sword-jin requested review from a team as code owners November 14, 2023 06:15
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Nov 14, 2023
@istio-testing
Copy link
Collaborator

Hi @sword-jin. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 14, 2023
@sword-jin
Copy link
Member Author

/release-notes-none

@sword-jin

This comment was marked as spam.

@zirain zirain added the release-notes-none Indicates a PR that does not require release notes. label Nov 14, 2023
@zirain
Copy link
Member

zirain commented Nov 14, 2023

/retest

cni/pkg/plugin/plugin.go Outdated Show resolved Hide resolved
pkg/util/sets/set_test.go Outdated Show resolved Hide resolved
@sword-jin sword-jin requested a review from howardjohn November 15, 2023 02:56
@istio-testing istio-testing merged commit 7e24bf9 into istio:master Nov 16, 2023
// Be aware that the order of elements is random so the string representation may vary.
// Use it only for debugging and logging.
func (s Set[T]) String() string {
return fmt.Sprintf("%v", s.UnsortedList())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it look better using SortedList?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants