Improve initServiceaccount by calculating once per service and reducing the lock time #47817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/S
istio-testing
added
size/M
|
with new Without this patch |
hzxuzhonghu
added
the
release-notes-none
|
/retest |
|
there seems to be no diff with benchmark? |
|
Sorry i copied wrong data |
|
@ramaraochavali updated in the above |
howardjohn
reviewed
Nov 10, 2023
| } | ||
| sa := sets.SortedList(spiffe.ExpandWithTrustDomains(accounts, ps.Mesh.TrustDomainAliases)) | ||
| key := serviceAccountKey{ | ||
| hostname: svc.Hostname, | ||
| namespace: svc.Attributes.Namespace, | ||
| port: port.Port, |
There was a problem hiding this comment.
Canwe remove the entire loop over ports now?
pilot/pkg/model/push_context.go
Outdated
| var accounts sets.String | ||
| func() { | ||
| // First get endpoint level service accounts | ||
| shard, f := env.EndpointIndex.ShardsForService(string(svc.Hostname), svc.Attributes.Namespace) | ||
| if f { | ||
| shard.RLock() | ||
| defer shard.RUnlock() | ||
| accounts = shard.ServiceAccounts | ||
| // copy here to reduce the lock time, the copy cost can be ignored |
There was a problem hiding this comment.
Why can it be ignored?
This seems less efficient; we always copy and before sometimes we avoided a copy. Benchmark shows this as well (its faster because of the port change)
There was a problem hiding this comment.
Because nornally there are very small number of sas, so i say that
istio-testing
added
size/L
howardjohn
approved these changes
Nov 13, 2023
|
/retest |
|
/test integ-security-multicluster |
|
/test all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR: