Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix istiod and proxy versions are incorrect in bug report #47703

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Fix istiod and proxy versions are incorrect in bug report #47703

merged 3 commits into from
Nov 2, 2023

Conversation

hanxiaop
Copy link
Member

@hanxiaop hanxiaop commented Nov 2, 2023 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:
If we are speifying commands like:

istioctl bug-report --include "default,foo"

We won't be able to fetch the reversions since we won't access istio-system and get the revision labels of the control plane components.

The output is:

...
The following Istio control plane revisions/versions were found in the cluster:
The following proxy revisions/versions were found in the cluster:
...

In this case, we can use annotations of the pods as well to get the revisions - they are injected by the webhook.
Sample output:

The following Istio control plane revisions/versions were found in the cluster:
Revision default:
&version.MeshInfo{
    {
        Component: "pilot",
        Revision:  "default",
        Info:      version.BuildInfo{Version:"1.20.0-rc.0", GitRevision:"1c84bbd12ed32b8b6280e451e12787eda0413ca8", GolangVersion:"", BuildStatus:"Clean", GitTag:"1.20.0-rc.0"},
    },
}

The following proxy revisions/versions were found in the cluster:
Revision default: Versions {1.20.0-rc.0, 1.21-dev, 1.20-dev}

@hanxiaop hanxiaop requested a review from a team as a code owner November 2, 2023 06:28
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2023
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2023
@istio-testing istio-testing merged commit 41bc89a into istio:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kfaseela kfaseela kfaseela approved these changes

Assignees
No one assigned
Labels
area/user experience size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanxiaop @istio-policy-bot @kfaseela @hzxuzhonghu @istio-testing