[add] affinity field to istiod #47639
Conversation
ymktmk
requested review from
costinm,
jacob-delgado,
Monkeyanator,
hanxiaop,
GregHanson and
a team
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
istio-testing
added
size/XS
|
Hi @ymktmk. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
istio-testing
added
ok-to-test
|
Since this existed in the chart this LGTM, but please add a release note. |
istio-testing
added
size/S
Co-authored-by: zirain <zirain2009@gmail.com>
| @@ -32,6 +32,8 @@ pilot: | |||
|
|
|||
| env: {} | |||
|
|
|||
| affinity: {} | |||
There was a problem hiding this comment.
I think tolerations were added alongside affinity, and neither was updated in the IstioOperator file. Should we add that as well?
There was a problem hiding this comment.
Should I add tolerations: [] in manifests/charts/istio-control/istio-discovery/values.yaml file ?
There was a problem hiding this comment.
I'd open another PR for that.
This reverts commit 6cfce2f.
Please provide a description of this PR:
This is an addition to helm Chart's value.yaml !
Even though the affinity field is actually provided, there was no field of it in values.yaml, so I added it.
https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/templates/deployment.yaml#L65~L68