Fix user created tag webhook being deleted by installer #47538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
hanxiaop
added
cherrypick/release-1.19
hanxiaop
force-pushed
the
fix-tag-webhook-being-deleted
branch
from
b044d6e to
e326fec
Compare
hanxiaop
added
the
do-not-merge/work-in-progress
hanxiaop
force-pushed
the
fix-tag-webhook-being-deleted
branch
from
e326fec to
f3f792e
Compare
istio-testing
removed
the
do-not-merge/work-in-progress
hanxiaop
force-pushed
the
fix-tag-webhook-being-deleted
branch
from
f3f792e to
27116d6
Compare
GregHanson
approved these changes
Nov 10, 2023
|
/retest |
|
In response to a cherrypick label: new pull request created: #47823 |
|
In response to a cherrypick label: new pull request created: #47824 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Fix #47423.
This is a regression introduced following #43897. Now user-generated labels will be identical to the installer created labels. As a result, a generated tag webhook will be managed by the installer as well.
However, they should be added/removed by using
istioctl tag set/remove.My approach is to remove the operator managed labels, since it was introduced by
MergeCopy- this reverts to the previous behavior.To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.