Expose cniNetnsDir Helm value to istioctl
#47499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/XS
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/expose-netns-istioctl
branch
from
91df183 to
a4b0118
Compare
bleggett
requested review from
costinm,
jacob-delgado,
Monkeyanator,
hanxiaop and
GregHanson
as code owners
bleggett
added
the
release-notes-none
2 tasks
howardjohn
approved these changes
Oct 20, 2023
jacob-delgado
approved these changes
Oct 21, 2023
|
/cherry-pick release-1.20 |
|
@bleggett: #47499 failed to apply on top of branch "release-1.20": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bleggett: new issue created for failed cherrypick: #47523 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bleggett
added a commit
to bleggett/istio
that referenced
this pull request
Oct 23, 2023
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
istio-testing
pushed a commit
that referenced
this pull request
Oct 23, 2023
…ikube issue (#47524) * Fix for #46163 - Make `netns` host node path configurable (#47444) * Fix for #46163 Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Release notes Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> --------- Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Expose #47444 to istioctl (#47499) Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> --------- Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #47444
Forgot that we can't just add things to Helm charts and have them also work in
istioctl. I don't love exposing all these flags but we do already expose the other CNI fields (bin dir, conf file, etc).