Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin certs to better location. #4748

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Conversation

myidpt
Copy link

@myidpt myidpt commented Apr 4, 2018

Move plugin certs from install/kubernetes to samples/certs.

@myidpt myidpt requested a review from wattli April 4, 2018 19:18
@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #4748 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4748    +/-   ##
=======================================
- Coverage      75%     75%   -<1%     
=======================================
  Files         293     298     +5     
  Lines       24241   25047   +806     
=======================================
+ Hits        18022   18592   +570     
- Misses       5485    5673   +188     
- Partials      734     782    +48
Impacted Files Coverage Δ
...ilot/pkg/networking/plugin/authn/authentication.go 13% <0%> (-53%) ⬇️
pilot/pkg/proxy/envoy/v2/ads.go 56% <0%> (-18%) ⬇️
mixer/adapter/stackdriver/stackdriver.go 55% <0%> (-15%) ⬇️
pilot/pkg/proxy/envoy/v1/header.go 88% <0%> (-12%) ⬇️
security/pkg/pki/ca/ca.go 69% <0%> (-8%) ⬇️
security/pkg/caclient/keycertbundlerotator.go 85% <0%> (-4%) ⬇️
pilot/pkg/proxy/envoy/v2/discovery.go 65% <0%> (-4%) ⬇️
pilot/pkg/proxy/envoy/v1/policy.go 84% <0%> (-3%) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-3%) ⬇️
pilot/pkg/proxy/envoy/v1/fault.go 81% <0%> (-2%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40635c5...c532b08. Read the comment docs.

@wattli
Copy link
Contributor

wattli commented Apr 5, 2018

Please remember to update the doc accordingly (in master branch)

Copy link
Contributor

@wattli wattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@myidpt
Copy link
Author

myidpt commented Apr 5, 2018

Sure. I'm working on it.

@istio-testing istio-testing removed the lgtm label Apr 9, 2018
@wattli
Copy link
Contributor

wattli commented Apr 9, 2018

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wattli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 3b98740 into istio:master Apr 9, 2018
@myidpt myidpt deleted the certs branch August 16, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants