Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multicluster secret filtering #47434

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Fix multicluster secret filtering #47434

merged 4 commits into from
Oct 18, 2023

Conversation

sschepens
Copy link
Contributor

@sschepens sschepens commented Oct 18, 2023 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:
Fix #47433

@sschepens sschepens requested a review from a team as a code owner October 18, 2023 18:19
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2023
@sschepens
Copy link
Contributor Author

@howardjohn

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2023
howardjohn
howardjohn approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sschepens
Copy link
Contributor Author

sschepens commented Oct 18, 2023 •
edited
Loading

@howardjohn gonna cherry-pick this into 1.19, ok? and 1.20

@howardjohn howardjohn added cherrypick/release-1.19 Set this label on a PR to auto-merge it to the release-1.19 branch cherrypick/release-1.20 Set this label on a PR to auto-merge it to the release-1.20 branch labels Oct 18, 2023
@sschepens
Copy link
Contributor Author

/test integ-cni

@istio-testing istio-testing merged commit 9b0332f into istio:master Oct 18, 2023
@istio-testing istio-testing mentioned this pull request Oct 18, 2023
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #47438

@istio-testing istio-testing mentioned this pull request Oct 18, 2023
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #47439

@sschepens sschepens deleted the fix-secret-filtering branch October 18, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cherrypick/release-1.19 Set this label on a PR to auto-merge it to the release-1.19 branch cherrypick/release-1.20 Set this label on a PR to auto-merge it to the release-1.20 branch size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multicluster secrets picked up outside of istio namespace
3 participants
@sschepens @istio-testing @howardjohn