Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry target ref #47162

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Telemetry target ref #47162

merged 9 commits into from
Oct 20, 2023

Conversation

MorrisLaw
Copy link
Contributor

@MorrisLaw MorrisLaw commented Sep 29, 2023 •
edited
Loading

Please provide a description of this PR:
Telemetry implementation for targetRef.

Fixes: #46844

@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2023
@MorrisLaw
Copy link
Contributor Author

/test all

@MorrisLaw
Copy link
Contributor Author

/retest

1 similar comment
@MorrisLaw
Copy link
Contributor Author

/retest

@MorrisLaw MorrisLaw force-pushed the telemetry-targetRef branch 2 times, most recently from f8484f4 to dcc7608 Compare October 4, 2023 20:48
@MorrisLaw
Copy link
Contributor Author

/retest

2 similar comments
@MorrisLaw
Copy link
Contributor Author

/retest

@MorrisLaw
Copy link
Contributor Author

/retest

@MorrisLaw MorrisLaw force-pushed the telemetry-targetRef branch from 2767e04 to 65253c1 Compare October 5, 2023 21:10
@MorrisLaw
Copy link
Contributor Author

/retest

1 similar comment
@MorrisLaw
Copy link
Contributor Author

/retest

@MorrisLaw
Copy link
Contributor Author

/retest

@MorrisLaw
Copy link
Contributor Author

/retest

1 similar comment
@MorrisLaw
Copy link
Contributor Author

/retest

@MorrisLaw MorrisLaw force-pushed the telemetry-targetRef branch from 87aa6f1 to 34da72c Compare October 9, 2023 20:59
@MorrisLaw MorrisLaw marked this pull request as ready for review October 9, 2023 20:59
@MorrisLaw MorrisLaw requested review from a team as code owners October 9, 2023 20:59
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Oct 9, 2023
@keithmattix
Copy link
Contributor

/retest

@MorrisLaw MorrisLaw self-assigned this Oct 16, 2023
@MorrisLaw MorrisLaw assigned howardjohn and kyessenov and unassigned MorrisLaw Oct 16, 2023
howardjohn
howardjohn reviewed Oct 16, 2023
View reviewed changes
pilot/pkg/model/telemetry.go Outdated Show resolved Hide resolved
pilot/pkg/model/telemetry.go Show resolved Hide resolved
pilot/pkg/model/telemetry.go Show resolved Hide resolved
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2023
@MorrisLaw
Copy link
Contributor Author

@howardjohn @hzxuzhonghu @zirain please review again. New commits add test coverage to validate that appendComputeTelemetries works as expected. They also address nits that were pointed out. Thank you!

@istio-testing istio-testing merged commit 8f16765 into istio:master Oct 20, 2023
@MorrisLaw MorrisLaw deleted the telemetry-targetRef branch October 20, 2023 13:03
@MorrisLaw MorrisLaw added the cherrypick/release-1.20 Set this label on a PR to auto-merge it to the release-1.20 branch label Oct 30, 2023
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #47648

@istio-testing istio-testing mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithmattix keithmattix keithmattix left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@zirain zirain zirain approved these changes

@howardjohn howardjohn Awaiting requested review from howardjohn

Assignees

@howardjohn howardjohn

@kyessenov kyessenov

Labels
cherrypick/release-1.20 Set this label on a PR to auto-merge it to the release-1.20 branch size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Telemetry Policy to use TargetRef instead of workloadSelector
7 participants
@MorrisLaw @istio-testing @keithmattix @howardjohn @zirain @hzxuzhonghu @kyessenov