Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some install codes #47007

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Clean up some install codes #47007

merged 2 commits into from
Sep 15, 2023

Conversation

hanxiaop
Copy link
Member

Please provide a description of this PR:

  1. We are not installing Istio resources during the installation so remove the custom resource check.

  2. The mtls files in analysis are not tested in anywhere.

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Ambient
  • Configuration Infrastructure
  • Docs
  • Dual Stack
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hanxiaop hanxiaop requested review from a team as code owners September 15, 2023 06:51
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 15, 2023
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2023
@hanxiaop hanxiaop added the release-notes-none Indicates a PR that does not require release notes. label Sep 15, 2023
@hanxiaop
Copy link
Member Author

/test release-notes

@howardjohn
Copy link
Member

/retest

@istio-testing istio-testing merged commit c1e5c31 into istio:master Sep 15, 2023
@hanxiaop hanxiaop mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@zirain zirain zirain approved these changes

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanxiaop @howardjohn @zirain @hzxuzhonghu @istio-testing