Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: fix dry-run prunes resources #46483

Merged
merged 2 commits into from
Aug 11, 2023
Merged

install: fix dry-run prunes resources #46483

merged 2 commits into from
Aug 11, 2023

Conversation

hanxiaop
Copy link
Member

@hanxiaop hanxiaop commented Aug 11, 2023 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

@hanxiaop hanxiaop requested a review from a team as a code owner August 11, 2023 07:27
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2023
@istio-testing istio-testing merged commit 380ad72 into istio:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
area/environments size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanxiaop @istio-policy-bot @howardjohn @istio-testing