Fix uninstall dry-run has confirmation #46347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/XS
ymesika
reviewed
Aug 7, 2023
| @@ -250,7 +250,7 @@ func preCheckWarnings(cmd *cobra.Command, kubeClient kube.CLIClient, uiArgs *uni | |||
| message += fmt.Sprintf(GatewaysRemovedWarning, gwList) | |||
| } | |||
| } | |||
| if uiArgs.skipConfirmation { | |||
| if dryRun || uiArgs.skipConfirmation { | |||
There was a problem hiding this comment.
Is it really dry running? It seems like it will just print the message and continue with the run.
There was a problem hiding this comment.
Dryrun itself is functioning well. This is simply to bypass confirmation in --dry-run mode - which is no need in dryrun, similar to other istioctl commands.
ymesika
approved these changes
Aug 7, 2023
| @@ -250,7 +250,7 @@ func preCheckWarnings(cmd *cobra.Command, kubeClient kube.CLIClient, uiArgs *uni | |||
| message += fmt.Sprintf(GatewaysRemovedWarning, gwList) | |||
| } | |||
| } | |||
| if uiArgs.skipConfirmation { | |||
| if dryRun || uiArgs.skipConfirmation { | |||
hanxiaop
added
the
release-notes-none
|
/test release-notes |
zirain
approved these changes
Aug 7, 2023
|
/cherry-pick release-1.19 |
|
@hanxiaop: new pull request created: #46476 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.