logging: cleanup errdict usage #46011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For istio#44683 Partially reverts istio/pkg#192 We current have an `errdict` mechanism, which is basically just a struct of k/v pairs to insert into logs. We made this builtin to our logging system. This adds a lot of complexity, and I don't think its needed. Instead, just add a helper to the errdict to make it add labels to the logger we want, and strip out all of the first-class support in `pkg/log`. This change moves us closer to being able to just swap `slog` in
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/XL
|
/retest |
hzxuzhonghu
approved these changes
Jul 14, 2023
ericvn
approved these changes
Jul 14, 2023
zirain
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #44683
Partially reverts istio/pkg#192
We current have an
errdictmechanism, which is basically just a structof k/v pairs to insert into logs. We made this builtin to our logging
system. This adds a lot of complexity, and I don't think its needed.
Instead, just add a helper to the errdict to make it add labels to the
logger we want, and strip out all of the first-class support in
pkg/log.This change moves us closer to being able to just swap
slogin (waiting for Go 1.21)