Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time measurement for istioctl bug-report command #45062

Merged
merged 4 commits into from
May 25, 2023
Merged

Add time measurement for istioctl bug-report command #45062

merged 4 commits into from
May 25, 2023

Conversation

syw14
Copy link
Contributor

@syw14 syw14 commented May 23, 2023 •
edited
Loading

Add time measurement for each block process time to the log.

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@syw14 syw14 requested a review from a team as a code owner May 23, 2023 18:44
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels May 23, 2023
@istio-testing
Copy link
Collaborator

Hi @syw14. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 23, 2023
howardjohn
howardjohn reviewed May 23, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

tools/bug-report/pkg/bugreport/bugreport.go Outdated Show resolved Hide resolved
tools/bug-report/pkg/bugreport/bugreport.go Outdated Show resolved Hide resolved
tools/bug-report/pkg/bugreport/bugreport.go Outdated Show resolved Hide resolved
@syw14 syw14 requested a review from howardjohn May 24, 2023 18:26
howardjohn
howardjohn approved these changes May 24, 2023
View reviewed changes
tools/bug-report/pkg/bugreport/bugreport.go Outdated Show resolved Hide resolved
@syw14 syw14 requested a review from howardjohn May 25, 2023 17:49
@syw14
Copy link
Contributor Author

syw14 commented May 25, 2023 •
edited
Loading

Also question please - how do we apply a new label to a PR? Thanks.

@howardjohn
Copy link
Member

once you join the org (which you should, see https://github.com/istio/community) you will get permission. In the meantime I will

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label May 25, 2023
@syw14
Copy link
Contributor Author

syw14 commented May 25, 2023

/retest

@istio-testing istio-testing merged commit 567afa1 into istio:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiaop hanxiaop hanxiaop left review comments

@howardjohn howardjohn Awaiting requested review from howardjohn

Assignees
No one assigned
Labels
area/user experience ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@syw14 @istio-testing @howardjohn @hanxiaop @istio-policy-bot