Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Envoy config dump info #44970

Merged
merged 4 commits into from
May 19, 2023
Merged

Missing Envoy config dump info #44970

merged 4 commits into from
May 19, 2023

Conversation

syw14
Copy link
Contributor

@syw14 syw14 commented May 17, 2023 •
edited
Loading

The current envoy config dump will skip all when detecting one err from one envoy config debug url. Change the logic to iterate them all.

  • Ambient
  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@syw14 syw14 requested a review from a team as a code owner May 17, 2023 22:20
@istio-policy-bot istio-policy-bot added area/user experience release-notes-none Indicates a PR that does not require release notes. labels May 17, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels May 17, 2023
@istio-testing
Copy link
Collaborator

Hi @syw14. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2023
@ericvn
Copy link
Contributor

ericvn commented May 18, 2023

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 18, 2023
howardjohn
howardjohn approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice find! Just some style nits

tools/bug-report/pkg/content/content.go Outdated Show resolved Hide resolved
tools/bug-report/pkg/content/content.go Outdated Show resolved Hide resolved
@istio-testing istio-testing merged commit 782c732 into istio:master May 19, 2023
@syw14 syw14 mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
area/user experience ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@syw14 @istio-testing @ericvn @howardjohn @istio-policy-bot