Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug report missing all logs for json logs #44919

Merged
merged 6 commits into from
May 19, 2023
Merged

Fix bug report missing all logs for json logs #44919

merged 6 commits into from
May 19, 2023

Conversation

syw14
Copy link
Contributor

@syw14 syw14 commented May 15, 2023 •
edited by istio-policy-bot
Loading

Fixes #44788

@syw14 syw14 requested a review from a team as a code owner May 15, 2023 17:50
@istio-policy-bot istio-policy-bot added area/user experience release-notes-none Indicates a PR that does not require release notes. labels May 15, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 15, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@istio-policy-bot
Copy link

😊 Welcome @syw14! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels May 15, 2023
@istio-testing
Copy link
Collaborator

Hi @syw14. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@syw14 syw14 changed the title Timestamp json Fix bug report missing all logs for json logs May 15, 2023
howardjohn
howardjohn reviewed May 15, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some testing for

tools/bug-report/pkg/processlog/processlog.go Outdated Show resolved Hide resolved
tools/bug-report/pkg/processlog/processlog.go Show resolved Hide resolved
tools/bug-report/pkg/processlog/processlog.go Show resolved Hide resolved
@howardjohn
Copy link
Member

/ok-to-tst

@ericvn
Copy link
Contributor

ericvn commented May 15, 2023

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 15, 2023
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2023
@syw14 syw14 requested review from howardjohn and hanxiaop May 17, 2023 00:49
howardjohn
howardjohn reviewed May 17, 2023
View reviewed changes
tools/bug-report/pkg/bugreport/flags.go Outdated Show resolved Hide resolved
tools/bug-report/pkg/config/config.go Show resolved Hide resolved
tools/bug-report/pkg/processlog/processlog.go Outdated Show resolved Hide resolved
@syw14
Copy link
Contributor Author

syw14 commented May 19, 2023

/retest

@istio-testing istio-testing merged commit ab23878 into istio:master May 19, 2023
@howardjohn
Copy link
Member

/cherrypick release-1.18
/cherrypick release-1.17

@istio-testing istio-testing mentioned this pull request May 22, 2023
Merged
@istio-testing
Copy link
Collaborator

@howardjohn: new pull request created: #45026

In response to this:

/cherrypick release-1.18
/cherrypick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiaop hanxiaop hanxiaop left review comments

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
area/user experience ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug-report: json log lines can be excluded
6 participants
@syw14 @istio-policy-bot @istio-testing @howardjohn @ericvn @hanxiaop