Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reflect.DeepEqual with service.Equals #43796

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Replace reflect.DeepEqual with service.Equals #43796

merged 1 commit into from
Mar 7, 2023

Conversation

dddddai
Copy link
Member

@dddddai dddddai commented Mar 7, 2023 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

@dddddai dddddai requested a review from a team as a code owner March 7, 2023 01:46
@istio-policy-bot istio-policy-bot added area/networking release-notes-none Indicates a PR that does not require release notes. labels Mar 7, 2023
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2023
@dddddai
Copy link
Member Author

dddddai commented Mar 7, 2023

/retest

@istio-testing istio-testing merged commit 9e3da86 into istio:master Mar 7, 2023
@dddddai dddddai deleted the svc-equal branch March 7, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

Assignees
No one assigned
Labels
area/networking release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dddddai @hzxuzhonghu @istio-testing @istio-policy-bot