Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyzer: cleanup unused params #43764

Merged
merged 4 commits into from
Mar 6, 2023
Merged

analyzer: cleanup unused params #43764

merged 4 commits into from
Mar 6, 2023

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Mar 3, 2023 •
edited by istio-policy-bot
Loading

This is never used / always true

Please provide a description of this PR:

@howardjohn
analyzer: cleanup unused params
375f26c 
This is never used / always true
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Mar 3, 2023
@howardjohn howardjohn requested review from a team as code owners March 3, 2023 23:05
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2023
ericvn
ericvn approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the two lines mentioned in the lint and gen check tests.

@istio-testing istio-testing merged commit 6216aa0 into istio:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiaop hanxiaop hanxiaop approved these changes

@ramaraochavali ramaraochavali ramaraochavali approved these changes

@ericvn ericvn ericvn approved these changes

@zirain zirain zirain approved these changes

Assignees

@ericvn ericvn

Labels
release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@howardjohn @zirain @ericvn @ramaraochavali @hanxiaop @istio-testing