Fix analyzing envoy filter when 'filter' field is missing #42832
Conversation
istio#42831 Before the change istioctl analyze was throwing SIGSEGV when optional field 'filter' was missing under EnvoyFilter.ListenerMatch.FilterChainMatch section.
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
😊 Welcome @pawelbeza! This is either your first contribution to the Istio istio repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
size/XS
|
Hi @pawelbeza. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
istio-testing
added
ok-to-test
|
@pawelbeza can you add a release note to highlight the fix? And include the issue # you have above in the release note |
istio-testing
added
size/S
dhawton
added
cherrypick/release-1.16
|
/cherry-pick release-1.15 /cherry-pick release-1.16 |
|
/cherry-pick release-1.16 |
|
/cherry-pick release-1.15 |
|
@zirain: new pull request created: #43959 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zirain: new pull request created: #43960 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zirain: new pull request could not be created: failed to create pull request against istio/istio#release-1.15 from head istio-testing:cherry-pick-42832-to-release-1.15: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-42832-to-release-1.15."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: #42831
Before the change
istioctl analyzewas throwing SIGSEGV when optional field 'filter' was missing under EnvoyFilter.ListenerMatch.FilterChainMatch section.Please provide a description of this PR:
Fixes SIGSEGV istioctl analyze issue described here #42831
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.