fix reload network endpoints #42825
Merged
fix reload network endpoints #42825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
istio-testing
added
the
size/XS
|
This regressed as part of this #42818. Sorry about that |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
added
size/S
hzxuzhonghu
reviewed
Jan 16, 2023
pilot/pkg/model/network.go
Outdated
| @@ -124,7 +124,7 @@ func (mgr *NetworkManager) reloadNetworkEndpoints() { | |||
| for _, networkconf := range oldNetworks.Networks { | |||
| for _, ne := range networkconf.Endpoints { | |||
There was a problem hiding this comment.
better to rename ne as well
costinm
reviewed
Jan 16, 2023
| for _, ne := range networkconf.Endpoints { | ||
| if len(ne.GetFromCidr()) > 0 { | ||
| newEndpoints = append(newEndpoints, ne) | ||
| for _, oe := range networkconf.Endpoints { |
There was a problem hiding this comment.
One of my new year resolutions is to start asking for more comments in the code :-). Few lines of comments explaining why we are doing this would help.
hzxuzhonghu
approved these changes
Jan 17, 2023
howardjohn
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42818