Switching revision in IstioOperator istio-gateway cache fix #42529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
istio-testing
added
the
do-not-merge/work-in-progress
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
😊 Welcome @chauhanshubham! This is either your first contribution to the Istio istio repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/M
|
Hi @chauhanshubham. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
istio-testing
removed
the
do-not-merge/work-in-progress
|
Thanks @chauhanshubham for this. Good catch. |
|
/ok-to-test |
istio-testing
added
ok-to-test
|
/release-note-none |
shivanshuraj1333
added
the
release-notes-none
|
/retest |
zirain
removed
the
release-notes-none
|
will take a look later, but this worth a release-notes. |
|
from this doc, I think change revision in IOP was not recommended. @howardjohn do you recall something about this? |
|
it is valid and documented in
https://istio.io/latest/docs/setup/additional-setup/gateway/#upgrading-gateways
…On Tue, Jan 10, 2023, 4:56 PM zirain ***@***.***> wrote:
from this doc
<https://istio.io/latest/docs/setup/install/operator/#canary-upgrade>, I
think change revision in IOP was not recommended.
@howardjohn <https://github.com/howardjohn> do you recall something about
this?
—
Reply to this email directly, view it on GitHub
<#42529 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXLPIHFPVS6N6EDQWNDWRYAM3ANCNFSM6AAAAAATE6HZZ4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
howardjohn
approved these changes
Jan 19, 2023
|
/test integ-security-multicluster |
morvencao
approved these changes
Jan 20, 2023
|
@zirain @howardjohn @morvencao do you see a need for release notes for this commit? |
howardjohn
added
the
release-notes-none
|
/retest |
bleggett
added a commit
to bleggett/istio
that referenced
this pull request
Jan 24, 2023
Update protobufs Add dep Derp Consider actually using TCP Hmm Fix this Missed one Add log message Logging Remove these Testing Missed this gawd Hmm Fix this Testing Ugh Whitespace Testing Invalid component Testing Fix logging Testt Add alt case Hmm Fix Fix 2 Fix routing Actually fix Fix this Don't cleanup gateways Aight I'm a goofus Tidy Testing Test Hmm Test Fix this Hmmm Oh Fix this Fix this test Hmm Test Hmm Hmm Cleanup Revert "Cleanup" This reverts commit 1f933b720c504dc82cdb5683e1e08e6d464f5f1a. Fix this Better comment Fix comment Automator: update proxy@master in istio/istio@master (istio#42865) Automator: update common-files@master in istio/istio@master (istio#42879) Automator: update istio/client-go@master dependency in istio/istio@master (istio#42880) improve wasm ecds comments (istio#42883) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Change no server certificate verify as warning level (istio#42876) * Change no server certificate verify as warning level * update Use latest helm dependency (istio#42891) Automator: update proxy@master in istio/istio@master (istio#42898) Automator: update common-files@master in istio/istio@master (istio#42900) Automator: update istio/client-go@master dependency in istio/istio@master (istio#42901) Automator: update proxy@master in istio/istio@master (istio#42907) Cleanup unused metadata (istio#42903) Update BASE_VERSION to master-2023-01-20T04-29-21 (istio#42913) Add Locality info to debug interface (istio#42884) Switching revision in IstioOperator istio-gateway cache fix (istio#42529) * switching revision in IstioOperator istio-gateway cache fix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * include all components Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Automator: update proxy@master in istio/istio@master (istio#42923) Automator: update istio/client-go@master dependency in istio/istio@master (istio#42926) add e2e for MetricDefinition (istio#42563) (istio#42924) * add e2e for MetricDefinition * fix lint * send http traffic only * fix prom query Co-authored-by: zirain <hejianpeng2@huawei.com> tf: ensure Check is always set (istio#42908) * tf: ensure Check is always set Avoid cases where we do not test anything * Always set * a few more * fix Initial messing about for PROXY protocol tests Fix this Automator: update proxy@master in istio/istio@master (istio#42865) Automator: update common-files@master in istio/istio@master (istio#42879) Automator: update istio/client-go@master dependency in istio/istio@master (istio#42880) improve wasm ecds comments (istio#42883) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Change no server certificate verify as warning level (istio#42876) * Change no server certificate verify as warning level * update Use latest helm dependency (istio#42891) Automator: update proxy@master in istio/istio@master (istio#42898) Automator: update common-files@master in istio/istio@master (istio#42900) Automator: update istio/client-go@master dependency in istio/istio@master (istio#42901) Automator: update proxy@master in istio/istio@master (istio#42907) Cleanup unused metadata (istio#42903) Update BASE_VERSION to master-2023-01-20T04-29-21 (istio#42913) Add Locality info to debug interface (istio#42884) Switching revision in IstioOperator istio-gateway cache fix (istio#42529) * switching revision in IstioOperator istio-gateway cache fix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * include all components Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Automator: update proxy@master in istio/istio@master (istio#42923) Automator: update istio/client-go@master dependency in istio/istio@master (istio#42926) add e2e for MetricDefinition (istio#42563) (istio#42924) * add e2e for MetricDefinition * fix lint * send http traffic only * fix prom query Co-authored-by: zirain <hejianpeng2@huawei.com> tf: ensure Check is always set (istio#42908) * tf: ensure Check is always set Avoid cases where we do not test anything * Always set * a few more * fix wasm: Send nack when there is not well-formed resource messages (istio#42928) * Send nack when there is an unmarshal error. Change-Id: I8143ba8bc8c292ce2de5abda0a4f0c70c111bf80 * change if structure to have more readability Change-Id: I076929d14dd1312b3717fe992352520223997354 * add unit tests Change-Id: I31831ea1ba87c99ffc0451a7f3a2cb02acc14d91 Automator: update proxy@master in istio/istio@master (istio#42931) Automator: update go dependencies@ in istio/istio@master (istio#42932) Fix TestDeltaEDS flake (istio#42925) improve appsv1 package import statement (istio#42946) Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io> Use the slices package for contains check (istio#42947) Automator: update common-files@master in istio/istio@master (istio#42948) reducing leaseduration, renewdeadline and retryperiod to shorten test time (istio#42920) add patch name to envoy filter crash log line (istio#42935) * add patch name to envoy filter crash log line Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * log line change Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com> use authn filter constant every where (istio#42936) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Automator: update istio/client-go@master dependency in istio/istio@master (istio#42949) Automator: update proxy@master in istio/istio@master (istio#42950) Automator: update proxy@master in istio/istio@master (istio#42953) Update master branch from 1.17 to 1.18 (istio#42875) * Update master branch from 1.17 to 1.18 * Remove older envoy filters * Fixup some version errors Update default k8s for test and buildkit (istio#42952) Use helm repo for integration tests instead of tarballs (istio#42864) * Use helm repo for integration tests instead of tarballs Signed-off-by: Faseela K <faseela.k@est.tech> * refactor Signed-off-by: Faseela K <faseela.k@est.tech> * configuration option for helm repo Signed-off-by: Faseela K <faseela.k@est.tech> * fix lint failure Signed-off-by: Faseela K <faseela.k@est.tech> * add --repo to individual commands Signed-off-by: Faseela K <faseela.k@est.tech> Signed-off-by: Faseela K <faseela.k@est.tech> Automator: update common-files@master in istio/istio@master (istio#42957)
istio-testing
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Test * Add basic integration tests for PROXY protocol and gateway Update protobufs Add dep Derp Consider actually using TCP Hmm Fix this Missed one Add log message Logging Remove these Testing Missed this gawd Hmm Fix this Testing Ugh Whitespace Testing Invalid component Testing Fix logging Testt Add alt case Hmm Fix Fix 2 Fix routing Actually fix Fix this Don't cleanup gateways Aight I'm a goofus Tidy Testing Test Hmm Test Fix this Hmmm Oh Fix this Fix this test Hmm Test Hmm Hmm Cleanup Revert "Cleanup" This reverts commit 1f933b720c504dc82cdb5683e1e08e6d464f5f1a. Fix this Better comment Fix comment Automator: update proxy@master in istio/istio@master (#42865) Automator: update common-files@master in istio/istio@master (#42879) Automator: update istio/client-go@master dependency in istio/istio@master (#42880) improve wasm ecds comments (#42883) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Change no server certificate verify as warning level (#42876) * Change no server certificate verify as warning level * update Use latest helm dependency (#42891) Automator: update proxy@master in istio/istio@master (#42898) Automator: update common-files@master in istio/istio@master (#42900) Automator: update istio/client-go@master dependency in istio/istio@master (#42901) Automator: update proxy@master in istio/istio@master (#42907) Cleanup unused metadata (#42903) Update BASE_VERSION to master-2023-01-20T04-29-21 (#42913) Add Locality info to debug interface (#42884) Switching revision in IstioOperator istio-gateway cache fix (#42529) * switching revision in IstioOperator istio-gateway cache fix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * include all components Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Automator: update proxy@master in istio/istio@master (#42923) Automator: update istio/client-go@master dependency in istio/istio@master (#42926) add e2e for MetricDefinition (#42563) (#42924) * add e2e for MetricDefinition * fix lint * send http traffic only * fix prom query Co-authored-by: zirain <hejianpeng2@huawei.com> tf: ensure Check is always set (#42908) * tf: ensure Check is always set Avoid cases where we do not test anything * Always set * a few more * fix Initial messing about for PROXY protocol tests Fix this Automator: update proxy@master in istio/istio@master (#42865) Automator: update common-files@master in istio/istio@master (#42879) Automator: update istio/client-go@master dependency in istio/istio@master (#42880) improve wasm ecds comments (#42883) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Change no server certificate verify as warning level (#42876) * Change no server certificate verify as warning level * update Use latest helm dependency (#42891) Automator: update proxy@master in istio/istio@master (#42898) Automator: update common-files@master in istio/istio@master (#42900) Automator: update istio/client-go@master dependency in istio/istio@master (#42901) Automator: update proxy@master in istio/istio@master (#42907) Cleanup unused metadata (#42903) Update BASE_VERSION to master-2023-01-20T04-29-21 (#42913) Add Locality info to debug interface (#42884) Switching revision in IstioOperator istio-gateway cache fix (#42529) * switching revision in IstioOperator istio-gateway cache fix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * include all components Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Automator: update proxy@master in istio/istio@master (#42923) Automator: update istio/client-go@master dependency in istio/istio@master (#42926) add e2e for MetricDefinition (#42563) (#42924) * add e2e for MetricDefinition * fix lint * send http traffic only * fix prom query Co-authored-by: zirain <hejianpeng2@huawei.com> tf: ensure Check is always set (#42908) * tf: ensure Check is always set Avoid cases where we do not test anything * Always set * a few more * fix wasm: Send nack when there is not well-formed resource messages (#42928) * Send nack when there is an unmarshal error. Change-Id: I8143ba8bc8c292ce2de5abda0a4f0c70c111bf80 * change if structure to have more readability Change-Id: I076929d14dd1312b3717fe992352520223997354 * add unit tests Change-Id: I31831ea1ba87c99ffc0451a7f3a2cb02acc14d91 Automator: update proxy@master in istio/istio@master (#42931) Automator: update go dependencies@ in istio/istio@master (#42932) Fix TestDeltaEDS flake (#42925) improve appsv1 package import statement (#42946) Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io> Use the slices package for contains check (#42947) Automator: update common-files@master in istio/istio@master (#42948) reducing leaseduration, renewdeadline and retryperiod to shorten test time (#42920) add patch name to envoy filter crash log line (#42935) * add patch name to envoy filter crash log line Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * log line change Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com> use authn filter constant every where (#42936) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Automator: update istio/client-go@master dependency in istio/istio@master (#42949) Automator: update proxy@master in istio/istio@master (#42950) Automator: update proxy@master in istio/istio@master (#42953) Update master branch from 1.17 to 1.18 (#42875) * Update master branch from 1.17 to 1.18 * Remove older envoy filters * Fixup some version errors Update default k8s for test and buildkit (#42952) Use helm repo for integration tests instead of tarballs (#42864) * Use helm repo for integration tests instead of tarballs Signed-off-by: Faseela K <faseela.k@est.tech> * refactor Signed-off-by: Faseela K <faseela.k@est.tech> * configuration option for helm repo Signed-off-by: Faseela K <faseela.k@est.tech> * fix lint failure Signed-off-by: Faseela K <faseela.k@est.tech> * add --repo to individual commands Signed-off-by: Faseela K <faseela.k@est.tech> Signed-off-by: Faseela K <faseela.k@est.tech> Automator: update common-files@master in istio/istio@master (#42957) * Fix these * Lint fixes * Fix comments * Lint fixes * More lint fixes * Be slightly more efficient with gateway creation * Lints * Update tests/integration/pilot/common/routing.go Co-authored-by: Lin Sun <lin.sun@solo.io> --------- Co-authored-by: Lin Sun <lin.sun@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Chauhan shubham@tetrate.io
Please provide a description of this PR:
Considering the following scenario
Assuming there are two istio control plane revisions running -
rev1andrev2iop1with revisionrev1with ingressGateway enabled. This is reconciled byistio-operator-rev1and skipped byistio-operator-rev2.iop1to use revisionrev2. The related objects like Deployment/ClusterRole/Service etc. must now be reconciled byistio-operator-rev2.iop1to move back to revisionrev1.istio-operator-rev1does not re-apply any related object manifests.After Step 3), istio objects like the gateway Deployment etc. are not reconciled by
istio-operator-rev1. This is becauseistio-operator-rev1never garbage collected objects from its local cache in Step 2) when the revision was updated.