Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pilot: ensure initialization of secure grpc server also when serving … #42248

Merged
merged 2 commits into from
Dec 5, 2022
Merged

pilot: ensure initialization of secure grpc server also when serving … #42248

merged 2 commits into from
Dec 5, 2022

Conversation

siiimooon
Copy link
Contributor

@siiimooon siiimooon commented Dec 2, 2022 •
edited
Loading

…certificates are loaded from non-custom locations

Please provide a description of this PR:
The bootstrap of Pilot should consider certificates at non-custom locations when considering whether to initialise the secure gRPC server.

Closes: #42249

@siiimooon
pilot: ensure initialization of secure grpc server also when serving …
c445e65 
…certificates are loaded from non-custom locations
@siiimooon siiimooon requested a review from a team as a code owner December 2, 2022 20:28
@istio-policy-bot
Copy link

😊 Welcome @siiimooon! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Dec 2, 2022
@istio-testing
Copy link
Collaborator

Hi @siiimooon. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@siiimooon siiimooon mentioned this pull request Dec 2, 2022
Closed
@ramaraochavali
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 5, 2022
@siiimooon
pilot: ensure initialization of secure grpc server also when serving …
e84f472 
…certificates are loaded from non-custom locations
@siiimooon siiimooon requested review from a team as code owners December 5, 2022 06:24
@siiimooon
Copy link
Contributor Author

/retest-required

@istio-testing istio-testing merged commit 34f0d22 into istio:master Dec 5, 2022
@zirain zirain added the cherrypick/release-1.16 Set this label on a PR to auto-merge it to the release-1.16 branch label Feb 3, 2023
@jewertow jewertow mentioned this pull request Feb 13, 2023
Merged
jewertow pushed a commit to jewertow/upstream-istio that referenced this pull request Feb 15, 2023
@siiimooon @jewertow
pilot: ensure initialization of secure grpc server also when serving … (
06bdf00 
istio#42248)

* pilot: ensure initialization of secure grpc server also when serving certificates are loaded from non-custom locations

* pilot: ensure initialization of secure grpc server also when serving certificates are loaded from non-custom locations
@jewertow jewertow mentioned this pull request Feb 15, 2023
Merged
istio-testing pushed a commit that referenced this pull request Feb 15, 2023
@jewertow @siiimooon
pilot: ensure initialization of secure grpc server also when serving … (
dff997a 
#42248) (#43352)

* pilot: ensure initialization of secure grpc server also when serving certificates are loaded from non-custom locations

* pilot: ensure initialization of secure grpc server also when serving certificates are loaded from non-custom locations

Co-authored-by: Si Mon <85333972+siiimooon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
area/environments cherrypick/release-1.16 Set this label on a PR to auto-merge it to the release-1.16 branch ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secure GRP Server of Pilot is not started, despite serving certificates have been provided
7 participants
@siiimooon @istio-policy-bot @istio-testing @ramaraochavali @howardjohn @hzxuzhonghu @zirain