sets: allow unordered types #41371
Merged
sets: allow unordered types #41371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/L
This allows us to use Sets for (almost) arbitrary types. The cost is that SortedList must become a function, not a method. Rewrite done using `gofmt -r 'x.SortedList() -> sets.SortedList(x)' -w **/*.go`. The alternative would be to create a duplicate Set type, UnoderedSet; in talking with Rama we both preferred this option.
howardjohn
force-pushed
the
sets/allow-unordered
branch
from
ac83b5d to
9f60122
Compare
lei-tang
approved these changes
Oct 11, 2022
ericvn
approved these changes
Oct 11, 2022
ramaraochavali
approved these changes
Oct 12, 2022
stevenctl
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use Sets for (almost) arbitrary types. The cost is that SortedList must become a function, not a method.
Rewrite done using
gofmt -r 'x.SortedList() -> sets.SortedList(x)' -w **/*.go.The alternative would be to create a duplicate Set type, UnoderedSet; in talking with Rama we both preferred this option.
Please provide a description of this PR: