Fix unit test flake #41192
Merged
Fix unit test flake #41192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-policy-bot
added
area/test and release
release-notes-none
istio-testing
added
the
size/S
howardjohn
reviewed
Sep 27, 2022
| @@ -46,15 +50,30 @@ func TestProfileList(t *testing.T) { | |||
|
|
|||
| func TestProfileListByurl(t *testing.T) { | |||
| g := gomega.NewWithT(t) | |||
| args := []string{"profile", "list", "--dry-run", "--manifests", "https://github.com/istio/istio/releases/download/1.15.0/istio-1.15.0-linux-amd64.tar.gz"} | |||
| tempChars := t.TempDir() | |||
| defer os.RemoveAll(tempChars) | |||
| args := []string{"profile", "list", "--dry-run", "--manifests", "https://github.com/istio/istio/releases/download/1.15.0/istio-1.15.0-linux-amd64.tar.gz"} | ||
| tempChars := t.TempDir() | ||
| defer os.RemoveAll(tempChars) | ||
| manifestsPath := filepath.Join(tempChars, "istio", "istio-1.15.0", "manifests") |
There was a problem hiding this comment.
you can use tgz.Create like TestInstallPackagePath, it makes this whole thing 1 liner
There was a problem hiding this comment.
actually now that I think about it, TestInstallPackagePath already covers this entirely.. maybe we just delete this test
There was a problem hiding this comment.
Thanks. I think we can just delete the test.
howardjohn
approved these changes
Sep 28, 2022
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Fix #41099