gateway-api: update types to read v1beta1 #41092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
istio-testing
added
the
do-not-merge/work-in-progress
|
/test all |
istio-testing
added
the
size/XXL
howardjohn
requested review from
a team,
costinm,
linsun,
stevenctl,
ericvn and
hzxuzhonghu
as code owners
istio-testing
removed
the
do-not-merge/work-in-progress
|
/retest |
howardjohn
force-pushed
the
gateway-api/use-beta-types
branch
from
1e7a061 to
5f84c40
Compare
istio-testing
added
the
needs-rebase
howardjohn
force-pushed
the
gateway-api/use-beta-types
branch
from
5f84c40 to
1e0b248
Compare
jacob-delgado
approved these changes
Sep 29, 2022
The upstream API is dropping support for the v1alpha2 types for HTTPRoute, Gateway, and GatewayClass in the next release. So, unlike Istio where we always read the alpha versions in Istiod, we must switch to reading the beta types or users on v0.6.0 (next release of API) will be broken. This means that the minimum version of the API is v0.5.0; most users are upgrading quickly since v0.4.0 was still an alpha API.
howardjohn
force-pushed
the
gateway-api/use-beta-types
branch
from
1e0b248 to
c5345e8
Compare
istio-testing
removed
the
needs-rebase
howardjohn
force-pushed
the
gateway-api/use-beta-types
branch
from
c5345e8 to
ef34bc9
Compare
ericvn
approved these changes
Sep 30, 2022
howardjohn
force-pushed
the
gateway-api/use-beta-types
branch
from
ef34bc9 to
454b6be
Compare
costinm
approved these changes
Sep 30, 2022
|
I think API moving to beta is a perfect moment to start recommending users, starting with 1.16, to use HttpRoute and k8s Gateway in preference to VS/old Istio Gateway. And maybe start updating istio.io examples. |
|
Frank is working on a huge docs pr for this:
istio/istio.io#12021
…On Fri, Sep 30, 2022 at 12:01 PM Costin Manolache ***@***.***> wrote:
I think API moving to beta is a perfect moment to start recommending
users, starting with 1.16, to use HttpRoute and k8s Gateway in preference
to VS/old Istio Gateway.
And maybe start updating istio.io examples.
—
Reply to this email directly, view it on GitHub
<#41092 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXLQGUYASI5Z7XSTWQ3WA42HJANCNFSM6AAAAAAQSD36OU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream API is dropping support for the v1alpha2 types for
HTTPRoute, Gateway, and GatewayClass in the next release. So, unlike
Istio where we always read the alpha versions in Istiod, we must
switch to reading the beta types or users on v0.6.0 (next release of
API) will be broken.
This means that the minimum version of the API is v0.5.0; most users are
upgrading quickly since v0.4.0 was still an alpha API.