Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore: cleanup stale entries #37336

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Feb 15, 2022

Aside from not being relevant anymore, if you happen to have these old
test files around (which are no longer generated), the tests will fail.
So make it obvious they exist and let git clean remove them.

Please provide a description of this PR:

Aside from not being relevant anymore, if you happen to have these old
test files around (which are no longer generated), the tests will fail.
So make it obvious they exist and let `git clean` remove them.
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Feb 15, 2022
@howardjohn howardjohn requested a review from a team as a code owner February 15, 2022 00:13
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2022
@ericvn
Copy link
Contributor

ericvn commented Feb 15, 2022

/retest

@istio-testing istio-testing merged commit d953f5a into istio:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants