Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test environments more #35354

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Test environments more #35354

merged 2 commits into from
Nov 18, 2021

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Sep 24, 2021 •
edited
Loading

For #34387

This has been extensively tested in prior commits of this PR that turned on the postsubmit (ie run all tests) mode. After this merges, I will send a PR to test-infra to move ipv6 and distroless to this new target.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Sep 24, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Sep 24, 2021
@howardjohn
Copy link
Member Author

/test all

@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR needs to be rebased before being merged labels Sep 24, 2021
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Oct 25, 2021
@howardjohn
Copy link
Member Author

/test all

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Oct 28, 2021
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2021
@howardjohn
Copy link
Member Author

/test all

1 similar comment
@howardjohn
Copy link
Member Author

/test all

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Oct 28, 2021
@howardjohn
Copy link
Member Author

/test all

1 similar comment
@howardjohn
Copy link
Member Author

/test all

@howardjohn
Copy link
Member Author

/test integ-ipv6-k8s-tests_istio

@howardjohn
Copy link
Member Author

/test all

@howardjohn
Copy link
Member Author

/test all

1 similar comment
@howardjohn
Copy link
Member Author

/test all

@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2021
@howardjohn
Copy link
Member Author

/test all

howardjohn added a commit to howardjohn/istio that referenced this pull request Nov 2, 2021
@howardjohn
Support WE for IPv6
d2ebcc8 
Tested in istio#35354

Fixes istio#35428
@howardjohn howardjohn mentioned this pull request Nov 2, 2021
Merged
howardjohn added a commit to howardjohn/istio that referenced this pull request Nov 2, 2021
@howardjohn
Add DeepCopy to echo CallOptions
a9f58bc 
When using nodeport, we mutate the Calloptions port (a pointer). This
means on subsequent retries things get messed up.

Tested in istio#35354
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 9, 2021
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 10, 2021
@howardjohn
Copy link
Member Author

/test all

howardjohn added a commit to istio/common-files that referenced this pull request Nov 10, 2021
@howardjohn
Enable metallb for IPv6
99d8a8b 
Tested in istio/istio#35354
Fixes istio/istio#34945
@howardjohn howardjohn mentioned this pull request Nov 10, 2021
Merged
howardjohn added a commit to howardjohn/istio that referenced this pull request Nov 10, 2021
@howardjohn
Update proxyv2 distroless image to reduce surface
afe409c 
This builds on `static`+libc rather than `base` which is bloated for our
use case

Tested in istio#35354
@howardjohn howardjohn mentioned this pull request Nov 10, 2021
Merged
@howardjohn
Copy link
Member Author

/test all

istio-testing pushed a commit to istio/common-files that referenced this pull request Nov 10, 2021
@howardjohn
Enable metallb for IPv6 (#489)
88caa00 
Tested in istio/istio#35354
Fixes istio/istio#34945
howardjohn added a commit to howardjohn/istio that referenced this pull request Nov 10, 2021
@howardjohn
Tweaks to test code to support IPv6
e389090 
Currently our IPv6 tests a tiny subset of our tests. I have recently
gotten it running on almost all of them, with the ones it doesn't work
with excluded. This testing is done in
istio#35354.

This doesn't yet expand our coverage, but we will in
istio#34387.
@howardjohn howardjohn mentioned this pull request Nov 10, 2021
Merged
istio-testing pushed a commit that referenced this pull request Nov 11, 2021
@howardjohn
Update proxyv2 distroless image to reduce surface (#36003)
7947ca1 
This builds on `static`+libc rather than `base` which is bloated for our
use case

Tested in #35354
istio-testing pushed a commit that referenced this pull request Nov 11, 2021
@howardjohn
Tweaks to test code to support IPv6 (#36005)
014288a 
Currently our IPv6 tests a tiny subset of our tests. I have recently
gotten it running on almost all of them, with the ones it doesn't work
with excluded. This testing is done in
#35354.

This doesn't yet expand our coverage, but we will in
#34387.
@howardjohn
Copy link
Member Author

/test all

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2021
@howardjohn howardjohn marked this pull request as ready for review November 18, 2021 00:14
@howardjohn howardjohn requested a review from a team as a code owner November 18, 2021 00:14
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Nov 18, 2021
@howardjohn howardjohn mentioned this pull request Nov 18, 2021
Merged
@istio-testing istio-testing merged commit 9d628bb into istio:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvn ericvn ericvn approved these changes

Assignees

@ericvn ericvn

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howardjohn @istio-testing @ericvn @istio-policy-bot