Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back empty check & delete to cni plugin. #33802

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

bianpengyuan
Copy link
Contributor

cni plugin library does not check on nil before calling passed in cmd. Got a crash when pod sandbox gets cleaned up.

Also add stack printing to cni plugin crash recovery.

@bianpengyuan bianpengyuan requested a review from a team as a code owner July 2, 2021 18:28
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 2, 2021
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 2, 2021
@bianpengyuan bianpengyuan added the release-notes-none Indicates a PR that does not require release notes. label Jul 2, 2021
@bianpengyuan
Copy link
Contributor Author

/retest

@istio-testing istio-testing merged commit 1a9b489 into istio:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants