Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving codeowners back to root. Trial 5 #2889

Merged
merged 5 commits into from
Jan 26, 2018
Merged

Moving codeowners back to root. Trial 5 #2889

merged 5 commits into from
Jan 26, 2018

Conversation

rshriram
Copy link
Member

No description provided.


Only confirmed, triaged and labelled issues should be filed here.
Please add the correct labels and epics (and priority and milestones if you have that information)
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would we remove this, it's useful

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once I get codeowners working, I can put it back. I am all out of ideas. IT works perfectly in istio/api where there is no .github folder. it is not working for this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the error/symptom when that directory exist ?

we do get already too many user issues filled here and this comment showing up in
https://github.com/istio/istio/issues/new

is important

Shriram Rajagopalan added 2 commits January 26, 2018 17:37
@rshriram rshriram changed the title remove empty .github folder Moving codeowners back to root. Trial 5 Jan 26, 2018
@ldemailly
Copy link
Member

/lgtm

Copy link
Contributor

@geeknoid geeknoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@rshriram rshriram merged commit 3a696c2 into master Jan 26, 2018
@rshriram rshriram deleted the codeowners-fix branch January 26, 2018 22:44
@istio-testing
Copy link
Collaborator

@rshriram: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-smoke.sh bb1d9d5 link /test e2e-smoke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants