Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate HTTP headers for istio-proxy probe requests #28537

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Avoid duplicate HTTP headers for istio-proxy probe requests #28537

merged 1 commit into from
Nov 3, 2020

Conversation

Monkeyanator
Copy link
Contributor

Fixes #28466

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Pull Request Attributes

Please check any characteristics that apply to this pull request.

[ ] Does not have any changes that may affect Istio users.

@Monkeyanator Monkeyanator requested a review from a team as a code owner November 3, 2020 16:40
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 3, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2020
@Monkeyanator Monkeyanator added the release-notes-none Indicates a PR that does not require release notes. label Nov 3, 2020
@Monkeyanator
Copy link
Contributor Author

/test release-notes_istio
/test integ-operator-controller-tests_istio

@Monkeyanator
Copy link
Contributor Author

/test integ-multicluster-k8s-tests_istio

@istio-testing istio-testing merged commit 45b0d1d into istio:master Nov 3, 2020
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #30954

This was referenced Feb 19, 2021
Merged
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #30955

@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio/istio#istio-testing:cherry-pick-28537-to-release-1.7 from release-1.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-28537-to-release-1.7."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

@wzshiming wzshiming mentioned this pull request Apr 7, 2021
Merged
wzshiming added a commit to wzshiming/istio that referenced this pull request Apr 7, 2021
@wzshiming
Revert "Avoid duplicate HTTP headers for istio-proxy probe requests (i…
1efd34a 
…stio#28537)"

This reverts commit 45b0d1d.
@wzshiming wzshiming mentioned this pull request Apr 7, 2021
Merged
istio-testing pushed a commit that referenced this pull request Apr 8, 2021
@wzshiming
Fix probe header (#31981)
4cde023 
* Revert "Fix allows repeated headers (#31866)"

This reverts commit f0d637f.

* Revert "Avoid duplicate HTTP headers for istio-proxy probe requests (#28537)"

This reverts commit 45b0d1d.

* Fix Probe Header logic

* Add test
istio-testing pushed a commit to istio-testing/istio that referenced this pull request Apr 12, 2021
@wzshiming @istio-testing
Revert "Avoid duplicate HTTP headers for istio-proxy probe requests (i…
27a2a97 
…stio#28537)"

This reverts commit 45b0d1d.
istio-testing pushed a commit to istio-testing/istio that referenced this pull request Apr 12, 2021
@wzshiming @istio-testing
Revert "Avoid duplicate HTTP headers for istio-proxy probe requests (i…
4d6e09d 
…stio#28537)"

This reverts commit 45b0d1d.
wzshiming added a commit to wzshiming/istio that referenced this pull request Apr 12, 2021
@wzshiming
Revert "Avoid duplicate HTTP headers for istio-proxy probe requests (i…
183fc44 
…stio#28537)"

This reverts commit 45b0d1d.
istio-testing pushed a commit that referenced this pull request Apr 12, 2021
@wzshiming
[release-1.8] Fix probe header (#32107)
35b0328 
* Revert "Avoid duplicate HTTP headers for istio-proxy probe requests (#28537)"

This reverts commit 45b0d1d.

* Fix Probe Header logic
istio-testing added a commit that referenced this pull request Apr 12, 2021
@istio-testing @wzshiming
[release-1.10] Fix probe header (#32104)
79d8df7 
* Revert "Fix allows repeated headers (#31866)"

This reverts commit f0d637f.

* Revert "Avoid duplicate HTTP headers for istio-proxy probe requests (#28537)"

This reverts commit 45b0d1d.

* Fix Probe Header logic

* Add test

Co-authored-by: Shiming Zhang <wzshiming@foxmail.com>
istio-testing pushed a commit that referenced this pull request Apr 14, 2021
@wzshiming
[release-1.9] Fix probe header (#32108)
4e8f4e6 
* Revert "Avoid duplicate HTTP headers for istio-proxy probe requests (#28537)"

This reverts commit 45b0d1d.

* Fix Probe Header logic

* Add test

* Conflict resolution
@howardjohn howardjohn mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

probe httpheaders are duplicated when using istio probe rewriting
4 participants
@Monkeyanator @istio-policy-bot @istio-testing @howardjohn