Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicated warning message for operator install command. #28532

Merged
merged 1 commit into from
Nov 3, 2020
Merged

fix duplicated warning message for operator install command. #28532

merged 1 commit into from
Nov 3, 2020

Conversation

morvencao
Copy link
Member

@morvencao morvencao commented Nov 3, 2020 •
edited by istio-policy-bot
Loading

resolve: #28527

[ ] Configuration Infrastructure
[ ] Docs
[ X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Pull Request Attributes

Please check any characteristics that apply to this pull request.

[ ] Does not have any changes that may affect Istio users.

@morvencao morvencao requested a review from a team as a code owner November 3, 2020 09:48
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2020
@morvencao morvencao added release-notes-none Indicates a PR that does not require release notes. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2020
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 3, 2020
@morvencao morvencao changed the title fix duplicated warning message for operator. fix duplicated warning message for operator install command. Nov 3, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2020
@morvencao morvencao requested a review from shamsher31 November 3, 2020 09:55
shamsher31
shamsher31 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@shamsher31 shamsher31 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. works fine now.

$ istioctl install --revision=1-9-0 --set hub=gcr.io/istio-testing -d manifests/
This will install the Istio 1.9.0 default profile with ["Istio core" "Istiod" "Ingress gateways"] components into the cluster. Proceed? (y/N) y
Detected that your cluster does not support third party JWT authentication. Falling back to less secure first party JWT. See https://istio.io/v1.9/docs/ops/best-practices/security/#configure-third-party-service-account-tokens for details.
✔ Istio core installed                                                                                                                              
✔ Istiod installed                                                                                                                                  
✔ Ingress gateways installed                                                                                                                        
✔ Installation complete

@shamsher31
Copy link
Member

/test integ-helm-tests_istio

@morvencao
Copy link
Member Author

/test integ-security-k8s-tests_istio

@morvencao
Copy link
Member Author

/test gencheck_istio

@istio-testing istio-testing merged commit 311edcd into istio:master Nov 3, 2020
@morvencao morvencao deleted the br_fix_duplicated_warning_message branch November 3, 2020 16:55
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: #28532 failed to apply on top of branch "release-1.8":

Applying: fix duplicated warning message for operator.
Using index info to reconstruct a base tree...
M	operator/cmd/mesh/install.go
Falling back to patching base and 3-way merge...
Auto-merging operator/cmd/mesh/install.go
CONFLICT (content): Merge conflict in operator/cmd/mesh/install.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix duplicated warning message for operator.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new issue created for failed cherrypick: #29180

@istio-testing istio-testing mentioned this pull request Nov 25, 2020
Closed
@morvencao morvencao mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn

@shamsher31 shamsher31

Assignees
No one assigned
Labels
area/environments cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

istioctl install: Duplicate warning: cluster does not support third party JWT authentication
5 participants
@morvencao @istio-policy-bot @shamsher31 @istio-testing @howardjohn