Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample ext_authz server #28512

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Conversation

yangminzhu
Copy link
Contributor

@yangminzhu yangminzhu commented Nov 3, 2020

This PR adds a sample ext_authz server, will be used in e2e tests for #28451 and also in a new task on istio.io.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Pull Request Attributes

Please check any characteristics that apply to this pull request.

[x] Does not have any changes that may affect Istio users.

@yangminzhu yangminzhu requested a review from a team as a code owner November 3, 2020 00:55
@istio-policy-bot istio-policy-bot added area/security release-notes-none Indicates a PR that does not require release notes. labels Nov 3, 2020
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 3, 2020
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 3, 2020
@yangminzhu yangminzhu force-pushed the e2e_extauthz branch 2 times, most recently from 9c0f51e to 9c96011 Compare November 3, 2020 01:35
@yangminzhu
Copy link
Contributor Author

@howardjohn could you also help take a look? Not sure who has the permission to push images to docker.io/istio.

@yangminzhu
Copy link
Contributor Author

/retest

@yangminzhu
Copy link
Contributor Author

/test integ-pilot-k8s-tests_istio

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can push it, maybe should merge then I will build+push once approved?

@yangminzhu
Copy link
Contributor Author

@howardjohn Added a Makefile to make it a bit easier to push, also updated the yaml to the docker.io/istio/ext-authz:0.5 so that we don't need a separate PR to update it.

@yangminzhu
Copy link
Contributor Author

@istio/wg-docs-maintainers can anyone approve the PR? thanks.

@yangminzhu
Copy link
Contributor Author

/test integ-pilot-k8s-tests_istio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants