Stop skipping lint/format in integration tests #28485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/L
bianpengyuan
approved these changes
Nov 2, 2020
stevenctl
approved these changes
Nov 2, 2020
lei-tang
approved these changes
Nov 2, 2020
istio-testing
added
the
needs-rebase
|
Not sure if you want to pull the automated common-files update PR: #28492 into this PR or not. You already have some of the common files and both PRs are needing a rebase. |
|
Ill pull it in manually |
howardjohn
force-pushed
the
lint/fix-tests
branch
from
80a2b81 to
2effc8a
Compare
istio-testing
removed
the
needs-rebase
howardjohn
force-pushed
the
lint/fix-tests
branch
2 times, most recently
from
8c4768c to
7707b0a
Compare
|
/retest |
howardjohn
force-pushed
the
lint/fix-tests
branch
from
7707b0a to
c8022ec
Compare
howardjohn
force-pushed
the
lint/fix-tests
branch
from
c8022ec to
b44483c
Compare
hzxuzhonghu
approved these changes
Nov 3, 2020
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.