Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support service.spec.externalIPs for multi-network gateway address #28406

Merged
merged 3 commits into from
Oct 29, 2020
Merged

support service.spec.externalIPs for multi-network gateway address #28406

merged 3 commits into from
Oct 29, 2020

Conversation

stevenctl
Copy link
Contributor

@stevenctl stevenctl commented Oct 29, 2020 •
edited
Loading

This allows usecases like #28381 without having to manually specify gateway IP in meshNetworks.

@stevenctl stevenctl requested a review from a team as a code owner October 29, 2020 17:12
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 29, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2020
@stevenctl stevenctl requested review from a team as code owners October 29, 2020 17:16
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2020
@stevenctl stevenctl added cherrypick/release-1.8 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2020
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2020
@istio-testing istio-testing merged commit 1e0c0ee into istio:master Oct 29, 2020
@istio-testing istio-testing mentioned this pull request Oct 29, 2020
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #28408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmittler nmittler nmittler approved these changes

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenctl @istio-testing @howardjohn @nmittler