Move 'istioctl istiod-config log' to 'istioctl experimental istiod log' #27799
Conversation
istio-testing
added
the
size/M
google-cla
bot
added
the
cla: yes
istioctl/cmd/istiodconfig.go
Outdated
| Example: ` # Retrieve information about istiod logging levels. | ||
| istioctl istiod-config log [<pod-name>] | ||
| Example: ` # Retrieve information about istiod logging levels. | ||
| istioctl istiod-config log |
There was a problem hiding this comment.
I think the example needs to be updated to use.
istioctl experimental istiod log
istioctl/cmd/istiodconfig.go
Outdated
| istioctl istiod-config <log>`, | ||
| Aliases: []string{"idc"}, | ||
| Example: ` # Retrieve information about istiod configuration. | ||
| istioctl istiod-config log`, |
There was a problem hiding this comment.
Is there 2 different commands or there is only one?
- istioctl x istiod log
- istioctl x istiod-config log
| Example: ` # Retrieve information about istiod logging levels. | ||
| istioctl experimental istiod log | ||
|
|
||
| # Retrieve information about istiod logging levels on a specific control plane pod. |
There was a problem hiding this comment.
Not sure if this is right, from the command it looks like that it can only get the logs of the istiod pod? or is this means that this can work with multiple revisions of the control plane?
There was a problem hiding this comment.
This command can only get/set the log level of an istiod pod.
It would be better if it worked differently, for example if it took a --revision <revision> and used that to match for istio.io/rev=<revision>. It would also be better if it set the level on ALL matching pods, not just one of them.
This work item is just about moving the command, not improving it.
|
|
||
| # Reset levels of all the loggers to default value (info). | ||
| istioctl istiod-config log -r | ||
| istioctl x istiod log -r |
There was a problem hiding this comment.
can you also add an example with aliases?
istioctl x istiod l istiod-5c868d8bdd-pmvgg
Resolves #27797