Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istioctl x des fix for weighted clusters #26911

Merged
merged 1 commit into from
Aug 31, 2020
Merged

istioctl x des fix for weighted clusters #26911

merged 1 commit into from
Aug 31, 2020

Conversation

rinormaloku
Copy link
Contributor

@rinormaloku rinormaloku commented Aug 30, 2020 •
edited by istio-policy-bot
Loading

This PR fixes #26910

Short description: When using istioctl describe pod, and the pod is routed to by a Weighted Cluster, the virtual services are not shown at all. This was due to the need to check for WeightedClusters when route.GetRoute().GetCluster() is empty

[x] User Experience

Please check any characteristics that apply to this pull request.

[x] Does not have any changes that may affect Istio users.

@rinormaloku rinormaloku requested a review from a team as a code owner August 30, 2020 16:42
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 30, 2020
@istio-policy-bot istio-policy-bot added area/user experience release-notes-none Indicates a PR that does not require release notes. labels Aug 30, 2020
@istio-policy-bot
Copy link

😊 Welcome @rinormaloku! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Aug 30, 2020
@istio-testing
Copy link
Collaborator

Hi @rinormaloku. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@esnible
Copy link
Contributor

esnible commented Aug 30, 2020

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 30, 2020
esnible
esnible approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@esnible esnible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rinor!

@istio-testing istio-testing merged commit 8cbde5f into istio:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esnible esnible esnible approved these changes

Assignees
No one assigned
Labels
area/user experience cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Istioctl x describe fails to list pod virtual services for weighted clusters
5 participants
@rinormaloku @istio-policy-bot @istio-testing @esnible @googlebot