remove all injected volumes when running remove-from-mesh/uninject #26782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
tariq1890
added
release-notes-none
esnible
approved these changes
Aug 24, 2020
|
In response to a cherrypick label: new pull request created: #26784 |
williamaronli
added a commit
to williamaronli/istio
that referenced
this pull request
Aug 25, 2020
* copymaster: (223 commits) Fix release notes to match schema (istio#26785) relocate role rbac manifests and use the correct label (istio#26787) Split out xds.FakeDiscoveryServer for use in configgen (istio#26774) Enhance central istiod: allow pass env from inject webhook, any kv, any order (istio#25968) (istio#25968) Add authorization to XDS connection (istio#26450) update bootstrap with wellknown names (istio#26797) Refactor SDS logic (istio#26655) remove all injected volumes when running remove-from-mesh/uninject (istio#26782) Always confirm install (even if customized) (istio#26776) Move XDS cache to model (istio#26779) Automator: update istio/api@master dependency in istio/istio@master (istio#26778) Optimize slice memory allocations at different places: (istio#26550) feat: istioctl operator dump - add revision flag (istio#26773) Cleanup XDS Plugins (istio#26724) Pilot: Config deep copy bug fix (istio#26752) Refactor proxy-config cmd into independent sub commands (istio#26641) Update Istio workload and Istio service dashboards (istio#25794) feat:istioctl x add-to-mesh and remove-from-mesh Should not affect OwnerReferences (istio#26721) fix serviceaccount mismatch issue for operator. (istio#26756) Increase timeout on traffic test (istio#26753) ... Change-Id: I37d27efa9a2533947c67f6387ba4a0270807b3c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uninject logic does not remove all of the volumes injected by proxy injector
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.