Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update (/revert) issue template #2302

Merged
merged 2 commits into from
Dec 30, 2017
Merged

update (/revert) issue template #2302

merged 2 commits into from
Dec 30, 2017

Conversation

ldemailly
Copy link
Member

There has been a slew of un-labeled and user-support type of issues filled directly against istio/istio

We should stick to triaging in istio/issues before promoting dev reviewed 'real' issues with labels etc

There has been a slew of un-labeled and user-support type of issues filled directly against istio/istio

We should stick to triaging in istio/issues before promoting dev reviewed 'real' issues with labels etc
Copy link
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to suggest asking on a mailing list before filing an issue? and/or searching through existing issues?

Please see https://istio.io/troubleshooting/ and if you are a user of Istio, please file issues in
https://github.com/istio/issues/issues instead of here

Only confirmed, triaged and labelled issues should be filled here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: did you want 'filled' or 'filed' ?

@@ -1,4 +1,7 @@
<!--
Please see https://istio.io/troubleshooting for potential workarounds.
Please see https://istio.io/troubleshooting/ and if you are a user of Istio, please file issues in
https://github.com/istio/issues/issues instead of here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end in a '.' ?

@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #2302 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
- Coverage   78.39%   78.35%   -0.04%     
==========================================
  Files          77       79       +2     
  Lines        7577     7680     +103     
==========================================
+ Hits         5940     6018      +78     
- Misses       1327     1341      +14     
- Partials      310      321      +11
Flag Coverage Δ
#broker 46.09% <ø> (-1.18%) ⬇️
#pilot 79.09% <ø> (-0.12%) ⬇️
#security 87.24% <ø> (-1.91%) ⬇️
Impacted Files Coverage Δ
pilot/adapter/config/memory/monitor.go 81.25% <0%> (-9.38%) ⬇️
pilot/tools/version/version.go
broker/pkg/version/version.go
security/pkg/platform/client.go 100% <0%> (ø)
security/pkg/platform/onprem.go 86.95% <0%> (ø)
security/pkg/platform/aws.go 65.85% <0%> (ø)
security/pkg/platform/gcp.go 94.59% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8888d4...75a6aa4. Read the comment docs.

@ldemailly
Copy link
Member Author

the help link covers the searching/troubleshooting

@geeknoid
Copy link
Contributor

/lgtm
/approve

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

@ldemailly: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 75a6aa4 link /test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly ldemailly merged commit a38db84 into master Dec 30, 2017
@ldemailly ldemailly deleted the ldemailly-patch-1 branch December 30, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants