Container build improvements #17336
Merged
Container build improvements #17336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
requested review from
howardjohn,
linsun and
rshriram
as code owners
googlebot
added
the
cla: yes
istio-testing
added
the
size/XL
howardjohn
reviewed
Sep 24, 2019
|
/test e2e-mixer-no_auth |
|
/retest |
ozevren
approved these changes
Sep 24, 2019
|
/retest |
- Producing all the genersted sources is now done using 'make gen' which runs the build steps within the build-tools container. - 'make fmt' now runs formatting steps from the build-tools container. - Update common files and common protos.
|
/retest |
|
/test pilot-e2e-envoyv2-v1alpha3 |
|
/retest |
douglas-reid
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Producing all the genersted sources is now done using
'make gen' which runs the build steps within the build-tools
container.
'make fmt' now runs formatting steps from the build-tools
container.
Update common files and common protos.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure